Closed Stoffo closed 9 months ago
@driftingly had to fix some Code Style Issues, now the tests should be green
Hi @Stoffo!
Thanks for your work on this! I recently switched the code style to be more in line with Laravel style. Can you pull down the latest changes to this branch and run composer fix
and composer rector
to fix the last issues here? You may also need to fix a PHPStan error that I saw pop up.
This will fix the PHPStan issues:
public function refactor(Node $node): ?Node
{
if ($node instanceof MethodCall) {
return $this->updateCall($node);
}
return null;
}
@driftingly Thanks for tips! I rebased the branch and ran the tools again 👍🏻
Thanks! I'll merge in as-is and clean up in main
Adds the following rule:
JsonCallToExplicitJsonCallRector
Changes Method Calls of
$this->json()
in PHPUnit Feature Tests to the more explicit version$this->postJson()
, $this->putJson(), etc..\RectorLaravel\Rector\MethodCall\JsonCallToExplicitJsonCallRector