search

driftingly / rector-laravel

Rector upgrades rules for Laravel
http://getrector.org
MIT License
500 stars 49 forks source link

[Fix] EloquentMagicMethodToQueryBuilderRector provides incorrect doc sample #172

Closed peterfox closed 7 months ago

peterfox commented 7 months ago

Changes

Why

Without this fix the composer docs script fails to generate the new rules documentation for the repo

Notes

I'm not sure why the command is now removing lots of examples. Possible that they've been added manually?

driftingly commented 7 months ago

Thanks @peterfox, looks like updating symplify/rule-doc-generator to the latest mostly fixes the issue:

-        "symplify/rule-doc-generator": "^11.0",
+        "symplify/rule-doc-generator": "^12.1.1",

There are still a few blocks removed, but those appear to be where the docs generator would insert an example configuration. Looks like it doesn't do that anymore 🤷

Can you update the rule-doc-generator and generate it again?

peterfox commented 7 months ago

@driftingly I've done as asked.