Add nikic/php-parser and sort packages

driftingly / rector-laravel

Rector upgrades rules for Laravel

http://getrector.org

MIT License

469 stars 48 forks source link

Add nikic/php-parser and sort packages #196

Closed peterfox closed 4 months ago

peterfox commented 4 months ago

Currently, the build fails because installing the packages allows for nikic/php-parser to install the latest version (^5.0) but currently the new API for v5 breaks PHPStan but resolving the PHPStan issues will cause the tests to fail. For now, locking the dev requirement keeps the build working as expected and doesn't appear to affect the running of tests.

driftingly commented 4 months ago

Thank you so much! I took a crack at this on friday, but couldn't figure out the issue. I don't think I would have figured it out.

peterfox commented 4 months ago

@driftingly it's not obvious right away. I think there will need to be fixes made in different repositories before we can make use of the v5 Parser