driftingly / rector-laravel

Rector upgrades rules for Laravel
http://getrector.org
MIT License
469 stars 48 forks source link

Remove redundant rule in laravel-static-to-injection set #208

Closed GeniJaho closed 2 months ago

GeniJaho commented 3 months ago

This rule is already present in a separate set LARAVEL_FACADE_ALIASES_TO_FULL_NAMES. It also has less to do with the 'static to injection' purpose of the set it belongs to. Since it's part of a set and is not a custom rule, it cannot be skipped, so the set is all or nothing.

If this is a desired change and the PR is merged, I think we would need a Minor release, since this changes the current behavior of the rule.