Closed megawubs closed 2 weeks ago
I've tried running composer fix-cs
but this changes a lot of code that I did not touch. I don't know if it's required before merge?
Indeed, this is best practice to work with names 👍
@megawubs Thanks for the PR and sorry for the late reply. We've just fixed the code style issue and can merge your PR. Can you please run composer fix-cs
once more?
I've just updated the code and ran composer fix-cs
This ensures a leading slash
\
is added to the namespace of the class that is newed up, ensuring the namespace is loaded from the root and not relative to the current namespace.Currently this rector breaks my code as it changes the code into something that does not work.
Note the missing
\
beforeApp
. This results in a namespace that can not be resolved. And broken testsBut with the leading slash, it's correct.