driftingly / rector-laravel

Rector upgrades rules for Laravel
http://getrector.org
MIT License
469 stars 48 forks source link

Do we use a fixed Linter configuration or go with the latest updates? #228

Open GeniJaho opened 2 weeks ago

GeniJaho commented 2 weeks ago

Hi @driftingly @peterfox, The current PRs are failing the build because of the latest Duster/CSFixer/Pint updates, not sure which ones. The Pint run fails because of the rule single_line_empty_body. I can add a pint.json file and skip it there, and it would solve the issue, but do we want to do that? The alternative is to run the duster on the whole project, take the latest defaults, and continue doing that in the future. I have no preference on using the single_line_empty_body rule or not, either way is fine IMO.

For now, I'm adding a pint.json config to keep the existing styling.