adds support for insert id for postgres

driftphp / reactphp-dbal

DBAL for ReactPHP on top of Doctrine

https://driftphp.io

41 stars 6 forks source link

adds support for insert id for postgres #17

Closed developernaren closed 4 years ago

developernaren commented 4 years ago

Adds support for insert id in postgres

Changes made

[x] For some reason the composer.lock does not have phpunit so did a composer install to update the composer
[x] Changed the container names to be more drift specific because it was conflicting with my containers in my local docker
[x] Extracted insert for all the drivers into their own class

developernaren commented 4 years ago

Circle Ci check is failing the tests. I had the same issue when I first ran the tests. It gave me an error table test.test does not exits. The I looked around in the test code. I changed the resetInfrastructure to createInfrastucture it worked and it started working in other consecutive test runs. I am not exactly sure what the issue is.

mmoreram commented 4 years ago

Tests are not passing

I'm not sure why EmptyDoctrineMysqlDriver should stop extending AbstractMySQLDriver
With this new implementation, when inserting an item in a non existing table, tests fail, basically because the query have RETURNING " without fields.
Once this last thing is solved, then tests are failing on line 556 - Failed asserting that null matches expected 1. - and sometimes the line 326

I'm fixing all these problems and I will update the PR and ping you.

Thanks!

mmoreram commented 4 years ago

@developernaren I've completed your PR here - https://github.com/driftphp/reactphp-dbal/pull/19