search

driftphp / reactphp-dbal

DBAL for ReactPHP on top of Doctrine
https://driftphp.io
41 stars 6 forks source link

Transactions #29

Closed bartvanhoutte closed 1 year ago

bartvanhoutte commented 2 years ago

PR adding transactions to Connection. See https://github.com/driftphp/reactphp-dbal/issues/28 for more information.

bartvanhoutte commented 2 years ago

Haven't added logging yet as being discussed in #28 .

marinhekman commented 1 year ago

@mmoreram

@bartvanhoutte I tested our project on your branch , and did not encounter any issues. To be clear, we do not use any transactions , so using drift react without it still works . If you test the transaction parts, and me and @mmoreram have reviewed the code, I think we can merge this into master. @mmoreram ? There was still some psr logging to work on ? Let's go to php 8 , we already moved to 8.1 here as well.

Marc, have you seen my last message? I think we can merge this branch for transaction support

mmoreram commented 1 year ago

Sorry, I've been completely out with my project. I've rebased and merged this. Good work, and sorry for forgetting.