Closed lmweber closed 3 years ago
Now that we have both spatialData and spatialCoords accessors, we should also think about consistency for the SpatialExperiment constructor.
spatialData
spatialCoords
SpatialExperiment
E.g. spatialCoords accessor returns a matrix, but spatialCoords argument in the constructor accepts a DataFrame.
DataFrame
Maybe one option is to simply replace the argument in the constructor, so have an argument spatialData instead of spatialCoords:
SpatialExperiment( ..., sample_id = "Sample01", spatialData = NULL, scaleFactors = 1, imageSources = NULL, image_id = NULL, loadImage = TRUE, imgData = NULL )
You're right, I forgot to correct that argument!
Update from today's testing:
Thanks!
done
Now that we have both
spatialData
andspatialCoords
accessors, we should also think about consistency for theSpatialExperiment
constructor.E.g.
spatialCoords
accessor returns a matrix, butspatialCoords
argument in the constructor accepts aDataFrame
.Maybe one option is to simply replace the argument in the constructor, so have an argument
spatialData
instead ofspatialCoords
: