search

drikusroor / vue-bootstrap-autocomplete

An autocomplete/typeahead component for Vue 2 and Bootstrap 4
https://drikusroor.github.io/vue-bootstrap-autocomplete/
MIT License
2 stars 11 forks source link

Bugfix: Select list items on enter keypress #11

Closed pager-itc closed 1 year ago

pager-itc commented 1 year ago

Selecting highlighted items from the dropdown list using the enter key wasn't working.

drikusroor commented 1 year ago

Sorry for responding so late, apparently my notifications aren't configured properly. I like your fix, but could you perhaps add a unit test for it as well?

pager-itc commented 1 year ago

No worries! I'm not sure how to write a test for this as it calls a method on the parent. The keyup.down and keyup.up handlers don't seem to be covered by unit tests either

drikusroor commented 1 year ago

Okay, I'll see if I can write some unit tests for it then :-)

pager-itc commented 1 year ago

Thank you!

drikusroor commented 1 year ago

Thank you! I've released the new package as a patch (2.15.3), see also https://github.com/drikusroor/vue-bootstrap-autocomplete/releases/tag/2.15.3 and https://www.npmjs.com/package/@vue-bootstrap-components/vue-bootstrap-autocomplete