search

driplineorg / dripline-cpp

C++ Implementation of the Dripline framework
http://driplineorg.github.io
Apache License 2.0
1 stars 0 forks source link

Feature/ghactions #76

Closed nsoblath closed 3 years ago

nsoblath commented 3 years ago

Known problem: branch==*.build workflow trigger is not working

nsoblath commented 3 years ago

Ok, this is finally in a state that's ready to review. The caveat from above still applies (*.build does not trigger run_tests). But the rest is working.

laroque commented 3 years ago

Why does the publish workflow include the tests that are also in the test workflow? I'd have thought you'd define the workflows each once and then reuse them on different triggers as needed.

nsoblath commented 3 years ago

I agree that that's the way it should be, but as far as I can tell, Actions doesn't easily allow that right now. I found a number of Issues and other threads requesting this sort of feature, and CircleCI was frequently cited as a service with this sort of feature built in.

The best alternative would have been to keep everything in one workflow file and include a bunch of logic to control which jobs were run under different conditions. That seemed more delicate to work out correctly. On the other hand, of course, this option is less convenient for future development because of the duplication. In the end I went with duplication over complicated logic.

nsoblath commented 3 years ago

Agreed. Thanks!