Invalid specifier should return an error

driplineorg / dripline-cpp

C++ Implementation of the Dripline framework

http://driplineorg.github.io

Apache License 2.0

1 stars 0 forks source link

Invalid specifier should return an error #92

Open nsoblath opened 1 year ago

nsoblath commented 1 year ago

Expected behavior for when a specifier is not handled should be that an error (i.e. 310) is returned. Right now that's not checked except for in Python with CMD requests, where if there's no function matching the specifier name, that error is returned.

nsoblath commented 2 days ago

To get a little more specific:

endpoint: cmd's are explicitly not handled; nothing to do here
hub: return code in cmd handling isn't right; fix to return code 310 (dl_service_error_invalid_specifier()) here: https://github.com/driplineorg/dripline-cpp/blob/8c2f794a7eaf76707e993113c81e4da7509ace7f/library/hub.cc#L154
service: doesn't reimplement do_cmd_request(), so nothing to do here