driplineorg / dripline-python

python implementation of project8/dripline
Apache License 2.0
3 stars 6 forks source link

Bug/127 payload check #146

Closed wsmithpnnl closed 7 months ago

wsmithpnnl commented 2 years ago

I've intercepted invalid result->scarab param via the try block, but need a sample invalid result to make sure that I can add appropriate unit tests (handling a general Exception in the current PR.)

Fixes

Testing

Prior to merging for releases:

laroque commented 2 years ago

I think an example was numpy.inf, maybe also numpy arrays, though those may be converted to a param_array and just round-trip to a list

wsmithpnnl commented 2 years ago

This all looks good. I'm approving this, but it should be tested as @laroque suggested before merging.

Thanks for the review, I'll try to get an appropriate unit test in to check those test cases before merging.