Open alindman opened 1 year ago
from a consistency perspective, dripline has traditionally sent unicode in packets on the mesh - the bytes encoding from the ethernet socket.recv is a bit of an anomaly should consider the most uniform implementation
_listen
should be retrieving a bytes object, this then gets decoded into a string https://github.com/driplineorg/dripline-python/blob/develop/dripline/implementations/ethernet_scpi_service.py#L186_send_commands
into a list with all other responses https://github.com/driplineorg/dripline-python/blob/develop/dripline/implementations/ethernet_scpi_service.py#L165send_to_device
https://github.com/driplineorg/dripline-python/blob/develop/dripline/implementations/ethernet_scpi_service.py#L142That this isn't the case indicates that the code is doing something unexpected somewhere in one of the passes. I would recommend tracking the type of this reply through this chain - particularly right before it leaves the ethernet_scpi_service in send_to_device
and right after on_get
of FormatEntity gets it.
Also more logging if there are no matches.
update and add/remove sections as needed
New Features
please describe new capabilities
Fixes
please list/describe an fixes, including links to related issues
Testing
please describe both unit tests included and any integration tests conducted
Prior to merging for releases:
CMakeLists.txt
fileappVersion
to be the new container image tag version inchart/Chart.yaml