driplineorg / dripline-python

python implementation of project8/dripline
Apache License 2.0
3 stars 6 forks source link

do_set_request() returns wrong reply with (in)valid specifier #64

Closed yadiw closed 4 years ago

yadiw commented 4 years ago

In unit tests for dripline.core.Endpoint, for its method on_set_request():

Given a request with a valid specifier:

Given a request with an invalid specifier:

p.s. if we run these tests for more than once, an segmentation fault would occur, and this is discussed in another issue.

laroque commented 4 years ago

In the tests, the methods now handle the ThrowReply producing those errors, this is resolved on branch dl3/unittest-fixes (No PR yet because it requires driplineorg/dripline-cpp:develop)

laroque commented 4 years ago

done last friday