drips-network / app

💧 Funding that flows — Drips Frontend
https://drips.network
GNU General Public License v3.0
31 stars 17 forks source link

Add ability to edit collaborators, name, description of a running voting round #1169

Open efstajas opened 1 month ago

efstajas commented 1 month ago

Currently, none of those things can be changed after the voting round has been started.

Editing the name & description should always be possible, even after voting is over (before publishing), and the new name & description will be taken over by the final Drip List upon publishing.

Regarding collaborators, WHILE THE LIST IS IN VOTING, it should be possible to:

If a collaborator is removed after they've voted already, their vote should be discarded.

I was thinking about whether we should only allow removing collaborators that haven't voted yet, but it makes little sense considering the publisher is free to alter the Drip List at any point after publishing anyway. It'd be really annoying if an entire voting round would have to be restarted just because it was discovered that someone who wasn't meant to be a collaborator voted early on.

brandonhaslegs commented 1 month ago

Design here https://www.figma.com/design/vyI7f996JF8zwhnXwAwXdC/%F0%9F%92%A7-Drips?node-id=10789-10637&t=N2jNd2oGDf6ZHX8R-1

image

And since we don't have the mini modal (now would be a great time to build that wouldn't it?!) then we'll probably end up with this design in the edit screen

image

I just don't think this is obvious enough. No one reads these things. And if we're deleting votes, it seems important to 🚨 warn the user

So maybe this is better?

image