drips-network / app

💧 Funding that flows — Drips Frontend
https://drips.network
GNU General Public License v3.0
32 stars 19 forks source link

Hide Projects and Drip Lists #1242

Open brandonhaslegs opened 1 month ago

brandonhaslegs commented 1 month ago

image

Since we've made so many test projects on chain, we need a way to hide them too.

Also want to be able to hide the test stuff I've done on mainnet 🥺

image
efstajas commented 3 weeks ago

So here's how I'm thinking to do this.

Generally

Project visibility

This one is simple. When you're in control of a project, you can set a visible boolean in metadata to false. Event processor should index this, and API should return a visible boolean in project data. If false, app treats it as hidden as described above. Projects without visible boolean (old metadata version) are presumed visible.

Drip Lists

A bit more complicated, because we also want lists to be hidden by default when transferred to you. I'm thinking:

That way, Drip Lists are visible after minting, can be hidden at will, and also are hidden by default after being transferred to someone else.

brandonhaslegs commented 3 weeks ago

When trying to split to a hidden Drip List or Project, the list editor should display an error like "The List / Project is hidden and cannot be split to".

would be cool if you could still split to a hidden list. for privacy's sake, some people might want to do this

efstajas commented 3 weeks ago

When trying to split to a hidden Drip List or Project, the list editor should display an error like "The List / Project is hidden and cannot be split to".

would be cool if you could still split to a hidden list. for privacy's sake, some people might want to do this

Idk. It wouldn't be private at all — the info would still be visible on-chain and even our API, just marked as hidden, so it'd be an illusion of privacy at best.

brandonhaslegs commented 3 weeks ago

When trying to split to a hidden Drip List or Project, the list editor should display an error like "The List / Project is hidden and cannot be split to".

would be cool if you could still split to a hidden list. for privacy's sake, some people might want to do this

Idk. It wouldn't be private at all — the info would still be visible on-chain and even our API, just marked as hidden, so it'd be an illusion of privacy at best.

we have to make that clear regardless

brandonhaslegs commented 3 weeks ago

in case of a list, possibly transferred to the recipient

what do you mean? how could being hidden also be the same state as transferred?

efstajas commented 3 weeks ago

in case of a list, possibly transferred to the recipient

what do you mean? how could being hidden also be the same state as transferred?

If we go with what I propose above, lists would be hidden automatically when transferred and would remain that way until explicitly set to visible by the new owner.

efstajas commented 3 weeks ago

@brandonhaslegs when you have capacity, could you update the designs with the above in mind?

need to know what splits & streams to hidden things look like, what viewing a hidden drip list or project looks like, and also probably update the visibility toggle to explain things clearer (no expectation of privacy etc.)

I'd also write up a docs page for this so we can link to it.

brandonhaslegs commented 3 weeks ago

All else sounds great to me!

brandonhaslegs commented 1 week ago

Drip List Image

Project Image

Can comment or look at the full design here

Worth noting that the support card would be gone when in the hidden state.