drips-network / app

💧 Funding that flows — Drips Frontend
https://drips.network
GNU General Public License v3.0
31 stars 16 forks source link

Make settings a modal #160

Open bordumb opened 1 year ago

bordumb commented 1 year ago

Problem

Flagging as bug as if a user intends to find settings, it's a bit confusing.

Currently, if we go to the upper-right drop-down and go to "Settings", that disrupts the user's flow:

image

Proposal

1. Consolidate "Settings" to drop-down

https://app.radicle.xyz/ currently does this as follows:

image

I'd recommend copy/pasting that for 2 reasons:

2. Create an "About" page

a. Add a "About" item in the drop-down list b. Move all of the "About" content to its own "About" page

efstajas commented 1 year ago

Definitely see your point — but let me try to clarify the thinking behind it.

There are already 5 additional settings planned: stream rate unit, primary color, custom tokens, font, and developer mode. These will all be added on this page. I'd argue that that's way too many things to put into a small floating drop-down, especially on mobile. Some of these settings may also require explanation beyond their title to make sense, which we wouldn't really have any space for in a drop-down.

Additionally, the theme toggle also isn't just a switch, but has four distinct modes, so wouldn't really fit into a narrow space well.

To the point of the "about"-type content — i think it's a pretty common pattern for things like OSS credits, "about" and "support" to be part of Settings. Both iOS and Android do that, as does e.g. the Discord app, Amazon, Google Maps (somewhat).

That said, once we have a few more real settings i could see us separating that to another "about" page linked from the menu drop-down for sure 👍

efstajas commented 1 year ago

@brandonhaslegs @evvvritt Would appreciate your input here.

brandonhaslegs commented 1 year ago

Let’s just put them in a modal instead of a page. Then you aren’t taken out of context.

Or could just take the mobile version of the settings page and put it all inside the dropdown.

I think about information is fine in settings. Or, you could just remove it. I don’t think you need an about page. The landing page is more of an about page anyway.

evvvritt commented 1 year ago

I like:

efstajas commented 11 months ago

@brandonhaslegs still think we should do this?

brandonhaslegs commented 11 months ago

Yes!