search

drips-network / app

💧 Funding that flows — Drips Frontend
https://drips.network
GNU General Public License v3.0
31 stars 17 forks source link

Add search functionality for claimed projects and Drip Lists #715

Open brandonhaslegs opened 1 year ago

brandonhaslegs commented 1 year ago

If I search for ethers.js in the search bar, I should be able to find it. It's a claimed project, so it exists in the Drips system, so I should be able to find it.

image image
evvvritt commented 1 year ago

I think we're also missing being able to search Drip Lists (by title)

brandonhaslegs commented 1 year ago

Yep should be a larger effort to improve search.

efstajas commented 11 months ago

Re searching GitHub repos by name:

This one is unfortunately quite tricky, unless i'm missing some other approach. If the user just enters the repo name, we need to somehow find out the name of the owner's repo on GH in order to be able to locate it. So we basically would have to integrate with GitHub's search endpoint, but it's rate-limited to only 10 requests / minute if unauthenticated. If authenticated (meaning the user would have to log in to Drips with GitHub), the limit is still only 30 requests / minute.

I think 10 searches / minute might be way too low for this to be worth implementing, unfortunately..? After 10 searches, the search function would just break for a while… or we'd have to say something like "Wait a minute before you continue searching"…? 🥴 idk! We also need to consider that as is, the search would be executed after a short debounce period, so as you type, more than one search may be executed.

30 / minute is better, but then we'd need to make people log in to their GitHub account on Drips… no idea what that would look like.

A completely different approach could be searching projects through our own custom Drips GQL API soon, but… it only knows about already-claimed projects. So, the search bar would require you to enter a full URL for unclaimed projects, but could find e.g. "ethers.js" fine, since it's already claimed.

Of course regardless of all of this, we could make it so that you "only" need to enter `username/repo-name" instead of the full GH URL.

Curious to hear your thoughts!

efstajas commented 11 months ago

search Drip Lists (by title)

we can do once our new API is up đź‘Ť

brandonhaslegs commented 11 months ago

This is only for claimed projects. i assumed this would be possible with our new api. i'm not saying we should search github.

efstajas commented 11 months ago

Yeah, this we can do for sure đź‘Ť

@jtourkos Just FYI — nothing we need to add now, but a simple "project name includes" string-filter for the projects query on the new API would probably be initially good enough for searching projects by name.