search

drips-network / app

💧 Funding that flows — Drips Frontend
https://drips.network
GNU General Public License v3.0
31 stars 17 forks source link

Generate a random Drip List ID when creating a new Drip List #991

Open jtourkos opened 7 months ago

jtourkos commented 7 months ago

There is no obvious reason to pre-calculate the Drip List ID based on the account's total minted count (to validate this before making any changes).

Also, after discussions, we came to the conclusion that this is hard to calculate correctly, if at all. Current logic has some buggy, (very)edge, cases that could result in a "token already minted" error.

The idea now is to generate a random ID and validate it on-chain by calling the NFTDriver.isSaltUsed before using it.

Relevant file: DripsListService.ts

evvvritt commented 7 months ago

is this a duplicate of #980 ? (if so close one?)