search

driscoll42 / ebayMarketAnalyzer

Scrape all eBay sold listings to determine average/median pricing, plot listings over time with trend lines, and extract to excel
195 stars 26 forks source link

Update Requests call to pass parameters more cleanly rather than buildin a string #43

Closed driscoll42 closed 3 years ago

driscoll42 commented 3 years ago

Is your feature request related to a problem? Please describe. Right now when making a requests call I am building a string using fstrings.

Describe the solution you'd like requests has passing parameters in the urls which makes it much cleaner: https://requests.readthedocs.io/en/latest/user/quickstart/#passing-parameters-in-urls

driscoll42 commented 3 years ago

Doesn't seem like it works well with how eBay wants the urls formatted. Not a real big issue anyway. Closing as won't fix.