search

driscollis / applications_with_wxpython

Code examples for the book, Creating GUI Application with wxPython
https://www.blog.pythonlibrary.org
116 stars 26 forks source link

Chapter 8 - version 1 - Save does not save edits #16

Closed cmcknight closed 5 years ago

cmcknight commented 5 years ago

Clicking the save button does not save the edits.

driscollis commented 5 years ago

Well, it does save the edits, but it's not updating the main app. Not sure why I didn't notice that, but I am working on a fix

cmcknight commented 5 years ago

Thanks, I just validated that the edits are in fact saved.

cmcknight commented 5 years ago

Also, I know you're working on a fix, but shouldn't the ObjectListView be cleared if you select another folder? :-)

driscollis commented 5 years ago

I could see an argument for the current way it works, but I like this suggestion better. I just updated the code with the fixes including clearing the widget on load.

cmcknight commented 5 years ago

Sure, but then the app would have to keep track of a lot of other information. Nice project extension but then again I’m guilty of editing ID3 tags using Vim. ;-)

On Mar 14, 2019, at 8:35 AM, Mike Driscoll notifications@github.com wrote:

I could see an argument for the current way it works, but I like this suggestion better. I just updated the code with the fixes including clearing the widget on load.

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/driscollis/applications_with_wxpython/issues/16#issuecomment-472922660, or mute the thread https://github.com/notifications/unsubscribe-auth/AAHtYTRZNqWVOONSlp7dtwskNvefSXNkks5vWmxKgaJpZM4byXC6.