drisso / SingleCellExperiment

Clone of the Bioconductor repository for the SingleCellExperiment package, see https://bioconductor.org/packages/devel/bioc/html/SingleCellExperiment.html for the official development version.
63 stars 17 forks source link

Modify behavior of withColData= in altExp(s) #58

Closed LTLA closed 3 years ago

LTLA commented 3 years ago

Setting to a character vector would specify which columns we wish to transplant from the main colData.

Furthermore, setting withColData=TRUE would cbind the main colData rather than replace the existing colData. This should have the same effect in most cases and will be more useful in the remaining cases where some colData exists.

In addition, we should support an equivalent option in the setters.

Each setting here directly reverses the effect of the corresponding setting in withColData=. The last two require some care to deal with the cases where there are duplicated names, but it mostly reverses the operation in the getter.

LTLA commented 3 years ago

Addressed in 0cce9f7964927b6868110925ffa316a6402acd2f.