Open davismcc opened 7 years ago
Hi @davismcc
This looks suspiciously similar to #36 . Do you have whole numbers in your count assay? If that's not the issue, it would be great if you can share a subset of your data for me to investigate further!
Hi Davide
Indeed, I do not have whole numbers in the count assay. I have used estimated counts from Salmon. Apologies if I missed the stipulation for whole numbers in the docs/workflow.
Obviously I can round my counts for this analysis and I guess that will work OK? In general it might be preferable to allow estimated counts from Salmon/kallisto/etc as possible input? In edgeR, for example, estimated counts work fine - we encourage users to provide raw counts, but the algorithms work perfectly well with non-integer values.
I'll follow up with a subset of the data. What's the best way to send a private link to you?
Best Davis
Hi Davis,
yes, I see your point, and it would definitely be nice to be able to use non-integer values in zinbwave. However, this leads to nasty errors that I can't still figure out. For now, I've decided to add an error upfront so that at least the users don't wait 13 hours before it fails. This is implemented in the new version of the package (0.99.8).
I would recommend that for now you round your counts and it would be great if you let me know if that fixes the problem. I will try to figure out why the algorithm fails with non-integer values, so I'll keep this open.
BTW, because of the git transition of Bioconductor I had to archive this version of the git repo and all the new activity will be at https://github.com/drisso/zinbwave.
Hi Davide
Error upfront is really sensible. Whatever you decide to/can implement for non-integers, best to know if there's a problem as early as possible.
I'm trying again now with rounded counts, so I'll let you know how that goes - fingers crossed!
I'll note the transition to the other repository - I have to do the same for scater.
Best D.
Hi Davide
I'm trying to run
zinbwave
on a moderately large dataset:After running for around 13 hours, the call to
zinbwave
threw the error below:Any ideas what might be going awry here?
Session info and warnings below. Let me know if you'd like to take a look at the data yourself, and I can share offline.
Best Davis
Warnings:
Session Info