search

drisso / zinbwave

Clone of the Bioconductor repository for the zinbwave package, see https://bioconductor.org/packages/zinbwave
43 stars 10 forks source link

Bug in computeObservationWeights? #43

Closed drisso closed 5 years ago

drisso commented 5 years ago

This line should be zinbwg[zinbwg < 1e-15] <- 1e-15

https://github.com/drisso/zinbwave/blob/6581bcc9f8554210f348e5f40bf09644365655f0/R/zinbwave.R#L48

am I right @koenvandenberge? I think I introduced this in the last release version...

koenvandenberge commented 5 years ago

Yes! This might explain the odd effects we've been seeing? Since all zeros got weight of 1e-15. Sorry I did not notice this either.

drisso commented 5 years ago

Yeah, I think so... ugh! :(

I'll fix it in both devel and release ASAP!

koenvandenberge commented 5 years ago

Great, thank you!

drisso commented 5 years ago

This has been fixed in both release and devel