fperraudeau commented 7 years ago

Hi Davide,

I created a branch to add functions to perform DE analysis for scRNA-seq. Could you have a look at the changes and tell me what you think? When I run devtools::check(), I get no error or note, but 1 warning because I have not added a test for new function glmWeightedF.

Also, in the previous release, we did not export function computeObservationalWeights(). So, I added a @export to export it.

codecov-io commented 7 years ago

Codecov Report

Merging #5 into master will decrease coverage by 11.93%. The diff coverage is 0%.

@@             Coverage Diff             @@
##           master       #5       +/-   ##
===========================================
- Coverage   92.41%   80.47%   -11.94%     
===========================================
  Files           6        7        +1     
  Lines         910     1045      +135     
===========================================
  Hits          841      841               
- Misses         69      204      +135

Impacted Files	Coverage Δ
R/detest.R	`0% <0%> (ø)`
R/normalized_values.R	`83.33% <0%> (-2.88%)`	:arrow_down:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 3f7f640...1493436. Read the comment docs.

drisso commented 7 years ago

It looks good to me, and just in time to add to the new release of Bioc!

When you have more time, it would be great if you could draft some unit tests for these functions!

Thanks again for all your work!

fperraudeau commented 7 years ago

Thank you, Davide. I'll add unit tests for the functions soon!

drisso / zinbwave

Add de stat test #5

Codecov Report