drisso / zinbwave

Clone of the Bioconductor repository for the zinbwave package, see https://bioconductor.org/packages/zinbwave
43 stars 10 forks source link

Adding beta parameter when it uses SolveRidgeRegression function #52

Closed fedeago closed 4 years ago

drisso commented 4 years ago

Hi @fedeago

the same issue happens for the zinbInitialize function. See https://github.com/drisso/zinbwave/blob/master/R/zinb_fit.R#L252

Do you mind changing that function as well?

fedeago commented 4 years ago

Hi, I should have solved it for both nb_initialize and zinb_initialized function, this is the same line in my branch: https://github.com/fedeago/zinbwave/blob/f833b9104a813324e12e777c90ef75516c758baa/R/zinb_fit.R#L252

drisso commented 4 years ago

Oh, right! Sorry my bad!

I will check the branch and merge it.