Closed Komosa closed 8 years ago
29.32%
Merging #10 into v0.4-dev will increase coverage by +5.37% as of
06e51e2
@@ v0.4-dev #10 diff @@
========================================
Files 26 26
Stmts 906 849 -57
Branches 52 68 +16
Methods 0 0
========================================
+ Hit 217 249 +32
- Partial 19 24 +5
+ Missed 670 576 -94
Review entire Coverage Diff as of
06e51e2
Powered by Codecov. Updated on successful CI builds.
Sorry it took me so long to look at this!
It looks good, but two small things stand out:
git rebase -i
, instead of having a commit subject that varies. I do like the idea of including more details in the message body, though.Ad2. I also appreciate that commit subjects created by bug are easily distinguishable from others. But I think, it will be also good to note differences among them.
Maybe some preffix will be best? Eg. bug:
:
bug: Updated issue "Proposal of more elaborate commit msg' subjects"
That seems like a reasonable compromise to me.. I'm not sure how it would scale to having multiple changes in the same commit, but my main concern is being able to easily identify commit messages that came from bug when rebasing.
Instead of always-the-same commit message we can contain information about what was changed. Tests updated to support both old and new format (simple/rich ?).