search

driusan / de

A Programmer's Text Editor
MIT License
429 stars 26 forks source link

golint straightforward fixes in all files #27

Closed josephholsten closed 8 years ago

josephholsten commented 8 years ago

This leaves the following golint warnings:

main.go:28:2: exported const ButtonLeft should have comment (or a comment on this block) or be unexported
actions/clipboard.go:8:1: exported function PasteClipboard should have comment or be unexported
actions/clipboard.go:51:1: exported function CopyClipboard should have comment or be unexported
actions/clipboard.go:73:1: exported function CutClipboard should have comment or be unexported
actions/deletecursor.go:7:1: exported function DeleteCursor should have comment or be unexported
actions/execute.go:21:1: exported function PerformAction should have comment or be unexported
actions/execute.go:43:1: exported function PerformTagAction should have comment or be unexported
actions/execute.go:79:1: exported function OpenOrPerformAction should have comment or be unexported
actions/execute.go:119:1: exported function RunOrExec should have comment or be unexported
actions/find.go:7:1: comment on exported function FindNext should be of the form "FindNext ..."
actions/find.go:38:1: exported function FindNextOrOpen should have comment or be unexported
actions/find.go:72:1: exported function FindNextOrOpenTag should have comment or be unexported
actions/insertcursor.go:7:1: exported function InsertSnarfBuffer should have comment or be unexported
actions/movecursor.go:7:1: exported function MoveCursor should have comment or be unexported
actions/open.go:117:1: exported function OpenFile should have comment or be unexported
actions/open.go:218:1: comment on exported function FocusViewport should be of the form "FocusViewport ..."
actions/register.go:14:1: exported function RegisterAction should have comment or be unexported
actions/savefile.go:11:5: exported var ErrNoFile should have comment or be unexported
actions/savefile.go:13:1: exported function SaveFile should have comment or be unexported
actions/defaults/defaultactions.go:51:1: exported function Put should have comment or be unexported
actions/defaults/defaultactions.go:57:1: exported function Get should have comment or be unexported
actions/defaults/defaultactions.go:70:1: exported function Exit should have comment or be unexported
actions/defaults/defaultactions.go:78:1: exported function ForceQuit should have comment or be unexported
actions/defaults/defaultactions.go:86:1: exported function SaveAndExit should have comment or be unexported
actions/defaults/defaultactions.go:92:1: exported function SaveOrExit should have comment or be unexported
actions/defaults/defaultactions.go:100:1: exported function Paste should have comment or be unexported
actions/defaults/defaultactions.go:104:1: exported function ResetTagline should have comment or be unexported
actions/defaults/defaultactions.go:108:1: exported function SwitchRenderer should have comment or be unexported
actions/defaults/undo.go:14:1: exported function Undo should have comment or be unexported
actions/defaults/viewport.go:18:1: exported function TermWidth should have comment or be unexported
actions/defaults/viewport.go:28:1: exported function WarnAlpha should have comment or be unexported
demodel/charbuffer.go:11:5: exported var ErrNoTagline should have comment or be unexported
demodel/charbuffer.go:13:1: exported method CharBuffer.AppendTag should have comment or be unexported
demodel/charbuffer.go:22:1: exported method CharBuffer.ResetTagline should have comment or be unexported
demodel/charbuffer.go:50:1: exported method CharBuffer.LoadSnarfBuffer should have comment or be unexported
demodel/charbuffer.go:63:1: exported method CharBuffer.JoinLines should have comment or be unexported
demodel/charbuffer.go:105:1: exported method CharBuffer.SaveSnarfBuffer should have comment or be unexported
demodel/model.go:54:1: comment on exported type Action should be of the form "Action ..." (with optional leading article)
demodel/model.go:58:1: comment on exported type Position should be of the form "Position ..." (with optional leading article)
demodel/model.go:73:6: exported type ScrollDirection should have comment or be unexported
demodel/model.go:76:2: exported const DirectionNone should have comment (or a comment on this block) or be unexported
demodel/viewer.go:9:5: exported var ErrUnsupportedOption should have comment or be unexported
kbmap/kbmap.go:13:5: exported var ErrInvalid should have comment or be unexported
kbmap/kbmap.go:14:5: exported var ErrExitProgram should have comment or be unexported
kbmap/kbmap.go:15:5: exported var ErrScrollDown should have comment or be unexported
kbmap/kbmap.go:16:5: exported var ErrScrollUp should have comment or be unexported
kbmap/kbmap.go:17:5: exported var ErrScrollLeft should have comment or be unexported
kbmap/kbmap.go:18:5: exported var ErrScrollRight should have comment or be unexported
kbmap/kbmap.go:23:2: exported const NormalMode should have comment (or a comment on this block) or be unexported
kbmap/normalmode.go:11:5: exported var Repeat should have comment or be unexported
plugins/shell/shell.go:22:1: comment on exported type TSBuffer should be of the form "TSBuffer ..." (with optional leading article)
plugins/shell/termrenderer.go:17:6: exported type TerminalRenderer should have comment or be unexported
plugins/shell/termrenderer.go:22:1: exported method TerminalRenderer.InvalidateCache should have comment or be unexported
plugins/shell/termrenderer.go:27:1: exported method TerminalRenderer.CanRender should have comment or be unexported
plugins/shell/termrenderer.go:31:1: exported method TerminalRenderer.RenderInto should have comment or be unexported
position/positions.go:10:5: exported var ErrInvalid should have comment or be unexported
position/positions.go:24:1: comment on exported function AltDotStart should be of the form "AltDotStart ..."
position/positions.go:30:1: comment on exported function AltDotEnd should be of the form "AltDotEnd ..."
position/positions.go:36:1: exported function TagDotStart should have comment or be unexported
position/positions.go:43:1: exported function TagDotEnd should have comment or be unexported
position/positions.go:50:1: exported function TagAltDotStart should have comment or be unexported
position/positions.go:56:1: exported function TagAltDotEnd should have comment or be unexported
position/positions.go:63:1: exported function BuffStart should have comment or be unexported
position/positions.go:69:1: exported function BuffEnd should have comment or be unexported
position/positions.go:76:1: exported function PrevChar should have comment or be unexported
position/positions.go:84:1: exported function NextChar should have comment or be unexported
position/positions.go:91:1: exported function PrevLine should have comment or be unexported
position/positions.go:126:1: exported function NextLine should have comment or be unexported
position/positions.go:195:1: exported function EndOfLine should have comment or be unexported
position/positions.go:213:1: exported function EndOfLineWithNewline should have comment or be unexported
position/positions.go:230:1: exported function StartOfLine should have comment or be unexported
position/positions.go:246:1: exported function CurWordStart should have comment or be unexported
position/positions.go:270:1: exported function CurWordEnd should have comment or be unexported
position/positions.go:292:1: exported function CurExecutionWordStart should have comment or be unexported
position/positions.go:316:1: exported function CurExecutionWordEnd should have comment or be unexported
position/positions.go:338:1: exported function CurTagExecutionWordStart should have comment or be unexported
position/positions.go:345:1: exported function CurTagExecutionWordEnd should have comment or be unexported
position/positions.go:352:1: exported function CurTagWordStart should have comment or be unexported
position/positions.go:359:1: exported function CurTagWordEnd should have comment or be unexported
position/positions.go:366:1: exported function NextWordStart should have comment or be unexported
position/positions.go:381:1: exported function PrevWordStart should have comment or be unexported
renderer/colors.go:7:1: comment on exported var NormalBackground should be of the form "NormalBackground ..."
renderer/colors.go:9:5: exported var InsertBackground should have comment or be unexported
renderer/colors.go:10:5: exported var DeleteBackground should have comment or be unexported
renderer/colors.go:11:5: exported var TaglineBackground should have comment or be unexported
renderer/colors.go:13:1: comment on exported var TextHighlight should be of the form "TextHighlight ..."
renderer/colors.go:15:5: exported var TextColour should have comment or be unexported
renderer/colors.go:16:5: exported var CommentColour should have comment or be unexported
renderer/colors.go:17:5: exported var KeywordColour should have comment or be unexported
renderer/colors.go:18:5: exported var BuiltinTypeColour should have comment or be unexported
renderer/colors.go:19:5: exported var StringColour should have comment or be unexported
renderer/colors.go:21:1: comment on exported var TagDelimitorColour should be of the form "TagDelimitorColour ..."
renderer/colors.go:23:5: exported var AttributeColour should have comment or be unexported
renderer/colors.go:24:5: exported var TagColour should have comment or be unexported
renderer/colors.go:25:5: exported var OperatorColour should have comment or be unexported
renderer/defaultsizecalcer.go:22:1: exported method DefaultSizeCalcer.InvalidateCache should have comment or be unexported
renderer/defaultsizecalcer.go:25:1: exported method DefaultSizeCalcer.Bounds should have comment or be unexported
renderer/imagemap.go:10:5: exported var ErrNoCharacter should have comment or be unexported
renderer/imagemap.go:12:6: exported type ImageLoc should have comment or be unexported
renderer/imagemap.go:17:6: exported type ImageMap should have comment or be unexported
renderer/imagemap.go:25:1: exported method ImageMap.At should have comment or be unexported
renderer/imagemap.go:34:1: comment on exported method ImageMap.Get should be of the form "Get ..."
renderer/imagemapcacher.go:20:1: exported method DefaultImageMapper.InvalidateCache should have comment or be unexported
renderer/imagemapcacher.go:23:1: exported method DefaultImageMapper.GetImageMap should have comment or be unexported
renderer/init.go:7:5: exported var MonoFontFace should have comment or be unexported
renderer/recalculatefont_darwin.go:12:1: exported function RecalculateFontFace should have comment or be unexported
renderer/register.go:18:1: exported function RegisterRenderer should have comment or be unexported
renderer/register.go:22:1: exported function GetRenderer should have comment or be unexported
renderer/register.go:30:1: exported function GetNamedRenderer should have comment or be unexported
renderer/tagline.go:21:1: exported method TaglineRenderer.InvalidateCache should have comment or be unexported
renderer/tagline.go:26:1: exported method TaglineRenderer.CanRender should have comment or be unexported
renderer/tagline.go:30:1: exported method TaglineRenderer.RenderInto should have comment or be unexported
renderer/gorenderer/gosyntax.go:17:6: exported type GoSyntax should have comment or be unexported
renderer/gorenderer/gosyntax.go:22:1: exported method GoSyntax.InvalidateCache should have comment or be unexported
renderer/gorenderer/gosyntax.go:26:1: exported method GoSyntax.CanRender should have comment or be unexported
renderer/gorenderer/gosyntax.go:30:1: exported method GoSyntax.RenderInto should have comment or be unexported
renderer/gorenderer/gosyntax.go:194:1: exported function StartsLanguageDeliminator should have comment or be unexported
renderer/gorenderer/gosyntax.go:209:1: exported function IsLanguageKeyword should have comment or be unexported
renderer/gorenderer/gosyntax.go:283:1: exported function IsLanguageType should have comment or be unexported
renderer/gorenderer/gosyntax.go:326:1: exported function IsEscaped should have comment or be unexported
renderer/hex/hex.go:14:6: exported type HexRenderer should have comment or be unexported
renderer/hex/hex.go:14:6: type name will be used as hex.HexRenderer by other packages, and that stutters; consider calling this Renderer
renderer/hex/hex.go:16:1: exported method HexRenderer.InvalidateCache should have comment or be unexported
renderer/hex/hex.go:18:1: exported method HexRenderer.CanRender should have comment or be unexported
renderer/hex/hex.go:21:1: exported method HexRenderer.Bounds should have comment or be unexported
renderer/hex/hex.go:40:1: exported method HexRenderer.GetImageMap should have comment or be unexported
renderer/hex/hex.go:43:1: exported method HexRenderer.RenderInto should have comment or be unexported
renderer/html/htmlsyntax.go:17:6: exported type HTMLSyntax should have comment or be unexported
renderer/html/htmlsyntax.go:22:1: exported method HTMLSyntax.InvalidateCache should have comment or be unexported
renderer/html/htmlsyntax.go:26:1: exported method HTMLSyntax.CanRender should have comment or be unexported
renderer/html/htmlsyntax.go:30:1: exported method HTMLSyntax.RenderInto should have comment or be unexported
renderer/imagerenderer/imagerender.go:10:2: a blank import should be only in a main or test package, or have a comment justifying it
renderer/imagerenderer/imagerender.go:14:6: exported type ImageRenderer should have comment or be unexported
renderer/imagerenderer/imagerender.go:18:1: exported method ImageRenderer.InvalidateCache should have comment or be unexported
renderer/imagerenderer/imagerender.go:21:1: exported method ImageRenderer.Bounds should have comment or be unexported
renderer/imagerenderer/imagerender.go:27:1: exported method ImageRenderer.CanRender should have comment or be unexported
renderer/imagerenderer/imagerender.go:53:1: exported method ImageRenderer.RenderInto should have comment or be unexported
renderer/imagerenderer/imagerender.go:61:1: exported method ImageRenderer.GetImageMap should have comment or be unexported
renderer/markdown/markdownsyntax.go:17:6: exported type MarkdownSyntax should have comment or be unexported
renderer/markdown/markdownsyntax.go:22:1: exported method MarkdownSyntax.InvalidateCache should have comment or be unexported
renderer/markdown/markdownsyntax.go:27:1: exported method MarkdownSyntax.CanRender should have comment or be unexported
renderer/markdown/markdownsyntax.go:31:1: exported method MarkdownSyntax.RenderInto should have comment or be unexported
renderer/nosyntax/nosyntax.go:14:1: comment on exported type NoSyntaxRenderer should be of the form "NoSyntaxRenderer ..." (with optional leading article)
renderer/nosyntax/nosyntax.go:20:1: exported method NoSyntaxRenderer.InvalidateCache should have comment or be unexported
renderer/nosyntax/nosyntax.go:24:1: exported method NoSyntaxRenderer.CanRender should have comment or be unexported
renderer/nosyntax/nosyntax.go:28:1: exported method NoSyntaxRenderer.RenderInto should have comment or be unexported
renderer/phprenderer/phpsyntax.go:17:6: exported type PHPSyntax should have comment or be unexported
renderer/phprenderer/phpsyntax.go:22:1: exported method PHPSyntax.InvalidateCache should have comment or be unexported
renderer/phprenderer/phpsyntax.go:27:1: exported method PHPSyntax.CanRender should have comment or be unexported
renderer/phprenderer/phpsyntax.go:31:1: exported method PHPSyntax.RenderInto should have comment or be unexported
renderer/phprenderer/phpsyntax.go:173:1: exported function StartsLanguageDeliminator should have comment or be unexported
renderer/phprenderer/phpsyntax.go:292:1: exported function IsLanguageType should have comment or be unexported
renderer/phprenderer/phpsyntax.go:335:1: exported function IsEscaped should have comment or be unexported
viewer/viewport.go:19:6: exported type Viewport should have comment or be unexported
viewer/viewport.go:33:6: exported type RequestRerender should have comment or be unexported
viewer/viewport.go:35:1: exported method Viewport.Rerender should have comment or be unexported
viewer/viewport.go:39:1: exported method Viewport.GetKeyboardMode should have comment or be unexported
viewer/viewport.go:43:5: exported var ErrKBLocked should have comment or be unexported
viewer/viewport.go:44:5: exported var ErrInvalidViewport should have comment or be unexported
viewer/viewport.go:46:1: exported method Viewport.ResetLocation should have comment or be unexported
viewer/viewport.go:55:1: comment on exported method Viewport.LockKeyboardMode should be of the form "LockKeyboardMode ..."
viewer/viewport.go:66:1: comment on exported method Viewport.UnlockKeyboardMode should be of the form "UnlockKeyboardMode ..."
viewer/viewport.go:78:1: exported method Viewport.SetKeyboardMode should have comment or be unexported
viewer/viewport.go:87:1: exported method Viewport.GetRenderer should have comment or be unexported
viewer/viewport.go:91:1: exported method Viewport.SetRenderer should have comment or be unexported
viewer/viewport.go:96:1: exported method Viewport.SetOption should have comment or be unexported
viewer/viewport.go:124:1: exported method Viewport.RenderInto should have comment or be unexported
driusan commented 8 years ago

Thanks! I've been meaning to run through everything with gometalinter, and eventually I'd have had to do this..