search

drivardxrm / CountryPicker.PCF

Country Picker PCF
MIT License
5 stars 2 forks source link

Official vs Common Name #24

Closed bwmodular closed 1 year ago

bwmodular commented 1 year ago

This is a great tool - thanks for developing it! Really Useful.

I don't quite understand why, for some countries, it displays the 'Common' name rather than the Official Name (eg Jordan rather than "Hashemite Kingdom of Jordan"), but for the UK it displays "United Kingdom of Great Britain and Northern Ireland" rather than "United Kingdom". No-one would ever call it that in practice, and it's not (for example) what would be written in the address. We would just put the common name: "United Kingdom". I couldn't see a way to control this, but I think most UK users would immediately be put off by this...

drivardxrm commented 1 year ago

@bwmodular you are right, I noticed that too regarding UK, the name seems odd to me.

The service used to fetch the countries is RestCountries v2 of the API (They are on v3 now but I never updated the control), i'm afraid of breaking changes to current users of the control.

If you check at the output for UK in API v2, "United Kingdom of Great Britain and Northern Ireland" is the name that they give. I see that the 'native name' could be used but this would break for other countries.

image

On the other hand, if I look at the v3 output, they give the common name and the long name I get this for UK image

I think I will make the switch soon to v3 and put a disclaimer for existing users

Thanks for your feedback

bwmodular commented 1 year ago

Thanks for the response David, much appreciated. I look forward to the v3 upgrade, whenever it happens.... :-)

drivardxrm commented 1 year ago

Hi @bwmodular I finally found some time to upgrade the control to the latest version of the Rest Countries API

You"ll be happy to find a more decent rendering for the UK ;) image

bwmodular commented 1 year ago

Wonderful, thanks for doing this, and thanks for letting me know.

Best wishes, Ben