Open cburroughs opened 11 months ago
I'm kind of on the fence about the value of adding an extra here. Would it work for us just to add type ignore at that import line? We don't actually use any of the pydantic types.
Let's go with the ignore fix here
We run mypy with
ignore_missing_imports = false
and then have an explicit allow list for packages. Sincecloudpathlib
imports pydantic (albeit behind a guard) but does not depends on it, mypy fails with :We would normally set
ignore_missing_imports
for justpydantic_core
, but that's somewhat wonky in this case becausepydantic_core
does have type stubs, it's just not a dependency.I think the most straightforward approach would be to add a pydantic extra to cloudpathlib, but there might be a fancier way to inform mypy directly of the "optional-ness" of the imports.