Closed kujenga closed 2 months ago
Attention: Patch coverage is 80.00000%
with 1 line
in your changes missing coverage. Please review.
Project coverage is 93.2%. Comparing base (
b776bee
) to head (147db5b
). Report is 1 commits behind head on 467-live-tests.
Files with missing lines | Patch % | Lines |
---|---|---|
cloudpathlib/azure/azblobclient.py | 75.0% | 1 Missing :warning: |
Also, one other thought: I think adding a rig for this is overkill. That will duplicate all the tests, which isn't necessary. I'd just do a single test with the custom scheme to show that piece works.
For all the instances you replaced, you should be able to get the cloud_prefix from the instance of the cloud_path passed to the method, no?
Good call, done!
Also, one other thought: I think adding a rig for this is overkill. That will duplicate all the tests, which isn't necessary. I'd just do a single test with the custom scheme to show that piece works.
Fair enough, done!
If there's anything else just let me know! I left them as separate commits to keep what I changed clear but happy to squash as well if you prefer.
great, let me know if there's anything else!
Hi @pjbull , any chance you'd be able to tag a release with this new functionality? Thank you!
@kujenga Yep! Need to get a release out for 3.13 anyway in the next few days.
This change is intended to make the default client implementations more flexible so that their scheme can be customized. This can be useful in scenarios where a subclass wants to implement a custom scheme on e.g. a S3 compatible API [1] but with a custom scheme so that the default S3 access is still also available.
[1] https://cloudpathlib.drivendata.org/stable/authentication/#accessing-custom-s3-compatible-object-stores
The tests have been updated to include a new s3-like rig which uses the new scheme override functionality.
(If there is a better strategy for tests or this seems like overkill let me know and happy to adjust! It seems a bit more work is needed to get them passing)
Closes #466
Contributor checklist:
CONTRIBUTING.md
Closes #issue
appears in the PR summary (e.g.,Closes #123
).HISTORY.md
with the issue that is addressed and the PR you are submitting. If the top section is not `## UNRELEASED``, then you need to add a new section to the top of the document for your change.