Closed pjbull closed 2 months ago
Attention: Patch coverage is 80.00000%
with 1 line
in your changes missing coverage. Please review.
Project coverage is 94.2%. Comparing base (
b776bee
) to head (16038bb
). Report is 1 commits behind head on master.
Files with missing lines | Patch % | Lines |
---|---|---|
cloudpathlib/azure/azblobclient.py | 75.0% | 1 Missing :warning: |
Live tests for #467
This change is intended to make the default client implementations more flexible so that their scheme can be customized. This can be useful in scenarios where a subclass wants to implement a custom scheme on e.g. a S3 compatible API [1] but with a custom scheme so that the default S3 access is still also available.
[1] https://cloudpathlib.drivendata.org/stable/authentication/#accessing-custom-s3-compatible-object-stores
The tests have been updated to include a new s3-like rig which uses the new scheme override functionality.
use single cloud_prefix
tests: switch to lighter-weight custom scheme tests
update HISTORY file for custom scheme support
update custom scheme tests to utilize pytest fixture
This isolates the implementation in response to PR feedback: https://github.com/drivendataorg/cloudpathlib/pull/467#discussion_r1742723302
DESCRIPTION_HERE
Closes #ISSUE
Contributor checklist:
CONTRIBUTING.md
Closes #issue
appears in the PR summary (e.g.,Closes #123
).HISTORY.md
with the issue that is addressed and the PR you are submitting. If the top section is not `## UNRELEASED``, then you need to add a new section to the top of the document for your change.