drivendataorg / cloudpathlib

Python pathlib-style classes for cloud storage services such as Amazon S3, Azure Blob Storage, and Google Cloud Storage.
https://cloudpathlib.drivendata.org
MIT License
478 stars 62 forks source link

Fix CloudPath.__truediv__ to return NotImplemented #480

Closed jayqi closed 1 month ago

jayqi commented 1 month ago

Return NotImplemented for CloudPath.__truediv__ in order to support operands that have implemented an __rtruediv__ that works with CloudPath.

Addresses an issue regarding compatibility with pandas-path surfaced in this issue:

github-actions[bot] commented 1 month ago

🚀 Deployed on https://deploy-preview-480--gallant-agnesi-5f7bb3.netlify.app

codecov[bot] commented 1 month ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 94.4%. Comparing base (5f5e054) to head (279fa86). Report is 1 commits behind head on master.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #480 +/- ## ====================================== Coverage 94.4% 94.4% ====================================== Files 23 23 Lines 1776 1776 ====================================== + Hits 1677 1678 +1 + Misses 99 98 -1 ``` | [Files with missing lines](https://app.codecov.io/gh/drivendataorg/cloudpathlib/pull/480?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=drivendataorg) | Coverage Δ | | |---|---|---| | [cloudpathlib/cloudpath.py](https://app.codecov.io/gh/drivendataorg/cloudpathlib/pull/480?src=pr&el=tree&filepath=cloudpathlib%2Fcloudpath.py&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=drivendataorg#diff-Y2xvdWRwYXRobGliL2Nsb3VkcGF0aC5weQ==) | `95.1% <100.0%> (+0.1%)` | :arrow_up: |