#229 Fix identification on LUNA

WGierke commented 6 years ago

I fixed the identification of LUNA nodules as far as it gets on my machine. This means that currently all tests in src/tests/test_identification.py are failing for me since I don't have 21 GB of RAM (if RUN_SLOW_TESTS is set to true). Maybe someone else can execute them and send me tracebacks for further error investigation?

Description

The problem was that sometimes the direct path to a MHD file was handed to the function instead of the path to the directory. The made changes should support now both alternatives.

Reference to official issue

This addresses #229 - identification test(s) should pass for luna scans.

How Has This Been Tested?

I added the test given in #229 .

CLA

[X] I have signed the CLA; if other committers are in the commit history, they have signed the CLA as well

lamby commented 6 years ago

Hey, can you clarify/fixup the "WIP" commit, and perhaps rebase to avoid that merge commit? *g*

WGierke commented 6 years ago

@lamby Done. I changed test_docker for faster testing purposes, but that has been reverted again :) Shouldn't have commited that.

lamby commented 6 years ago

I don't have 21 GB of RAM

Amateur!

WGierke commented 6 years ago

I really appreciate your offer to run the identification tests on your machine and to send me possible occurring stack traces @lamby ! :grin:

drivendataorg / concept-to-clinic