Detect and select: mark\dismiss candidates

drivendataorg / concept-to-clinic

ALCF Concept to Clinic Challenge

https://concepttoclinic.drivendata.org/

MIT License

367 stars 147 forks source link

Detect and select: mark\dismiss candidates #254

Closed Serhiy-Shekhovtsov closed 6 years ago

Serhiy-Shekhovtsov commented 6 years ago

Implemented functionality for reviewing nodule candidates. Now user can set whether the nodule was marked for further analysis or not.

NOTE: this PR depends on #250 and has only 3 commits on top of it.

Reference to official issue

It's an improvement of #148

Screenshot:

detect-and-select-review full size image

CLA

[x] I have signed the CLA; if other committers are in the commit history, they have signed the CLA as well

reubano commented 6 years ago

Works like a charm! Rebasing should sort out the errors :)

Serhiy-Shekhovtsov commented 6 years ago

I still have to add API test for this feature. Will make a new PR for that.

reubano commented 6 years ago

I still have to add API test for this feature. Will make a new PR for that.

@Serhiy-Shekhovtsov if you don't have time to do this fairly soon, can you create an issue for it?

isms commented 6 years ago

@reubano it's already pretty much taken care of: https://github.com/concept-to-clinic/concept-to-clinic/blob/master/interface/backend/cases/tests.py#L105-L119

reubano commented 6 years ago

@isms from my understanding, those are new DB state tests. The previous server response tests were removed. Are you saying these are actually one in the same?

Serhiy-Shekhovtsov commented 6 years ago

Guys, test are a little bit different. Old tests were checking the API output while new one is testing outcome(the DB result).