drivendataorg / concept-to-clinic

ALCF Concept to Clinic Challenge
https://concepttoclinic.drivendata.org/
MIT License
367 stars 147 forks source link

#275 /<algorithm>/predict/: Only expect GET or POST requests #289

Closed WGierke closed 6 years ago

WGierke commented 6 years ago

While skimming through code that still needs to be tested in the prediction service, I noticed this line that prevented the file from being completely covered by tests. The reason was that the condition was never false since the methods=['GET', 'POST'] parameter prevents any other request than a POST request from reaching this LOC.

CLA

lamby commented 6 years ago

Thanks, and good spot!