Closed jayqi closed 5 months ago
A little on the fence with a slight preference for dataset.py, features.py and plot.py over the ones that start some_. Removes the rename step and people can customize as desired if they want but the default doesn't require it.
The reason I like the some_
prefix is that it's a sign post that the name is not special or expected to be final and that people should pick a real name for it.
I don't really like having a default generic name. If someone were really going to just have a single dataset
module, then having data.dataset
, features.features
, etc. is weird and we should just get rid of the directory layers.
Your Render PR Server URL is https://cookiecutter-data-science-pr-354.onrender.com.
Follow its progress at https://dashboard.render.com/static/srv-coaurquv3ddc73edhebg.
Well okay. Since we've got some real stuff in the boilerplate now with imports like
from {{ cookiecutter.module_name }}.config import FIGURES_DIR, PROCESSED_DATA_DIR
this breaks linting and formatting.
Options:
Agreed about #2 for linting.
@pjbull Should be good to go! I opened these two issues to capture some of the items we're punting on:
Here is a stab at modernizing the boilerplate.
config
module which:load_dotenv
PROJ_ROOT
Open to opinions here. I also considered just getting rid of all of the CLI example modules.