Closed IshaShah27 closed 6 months ago
All modified and coverable lines are covered by tests :white_check_mark:
Project coverage is 96.80%. Comparing base (
67b2964
) to head (a85f210
).
:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.
@pjbull I made a few more changes to this -- want to take a quick look?
Is there anything else that needs to happen before I merge? Are the steps I took (in the PR description) the right ones to make sure all relevant files are updated?
I think this is good. Pretty sure just changing the yaml is the only required thing. Generated files get overwritten when PR is merged to main
:
https://github.com/drivendataorg/deon/blob/main/.github/workflows/examples.yml#L20-L29
Ah got it excellent. Going ahead with the merge!
Is there anything else that needs to happen before I merge? Are the steps I took (in the PR description) the right ones to make sure all relevant files are updated?
For future reference, contributing doc is here: https://github.com/drivendataorg/deon/blob/main/CONTRIBUTING.md
^ Contributing doc covers adding examples and adding checklist items, but doesn't explicitly cover changing the main README so wanted to make sure
related to #167
--Related academic study
when the study is prominently linked in the article (to improve readability)CONTRIBUTING.md
(previously it went here but didn't give instructions)Steps used to update:
deon/assets/examples_of_ethical_issues.yml
make docs
to updatedocs/docs/examples.md
docs/md_templates/_common_body_pt-BR.tpl
anddocs/md_templates/_common_body.tpl
make render_markdown
to update contribution link inREADME.md
anddocs/docs/index.md
Questions:
deon/assets/examples_of_ethical_issues_pt-BR.yml
?