drivendataorg / nbautoexport

Automatically export Jupyter notebooks to various file formats (.py, .html, and more) on save.
https://nbautoexport.drivendata.org/
MIT License
72 stars 9 forks source link

Add new clean, convert, export commands #30

Closed jayqi closed 4 years ago

jayqi commented 4 years ago

Added new commands to the CLI. The summary of the commands are as follows:

Additional changes:

Additional refactoring:

How stuff works:

Fixed some bugs:

Looking for feedback:

TODO:

Known issues, thinking will save these for the future:

Note: I tried to get the root of the CLI to point to install but it doesn't work, because other subcommands will conflict with arguments.

Resolves #20, #21

jayqi commented 4 years ago

@pjbull @r-b-g-b this PR is ready.

Apologies that it is quite hefty, but the new functionality I wanted to add really required some significant refactoring. Also a lot of it is tests! This PR is at 99% test coverage.

codecov[bot] commented 4 years ago

Codecov Report

Merging #30 into master will increase coverage by 3.58%. The diff coverage is 98.54%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #30      +/-   ##
==========================================
+ Coverage   94.73%   98.31%   +3.58%     
==========================================
  Files           2        8       +6     
  Lines         152      357     +205     
==========================================
+ Hits          144      351     +207     
+ Misses          8        6       -2     
Impacted Files Coverage Δ
nbautoexport/export.py 95.52% <95.52%> (ø)
nbautoexport/jupyter_config.py 96.36% <96.36%> (ø)
nbautoexport/__init__.py 100.00% <100.00%> (ø)
nbautoexport/__main__.py 100.00% <100.00%> (ø)
nbautoexport/clean.py 100.00% <100.00%> (ø)
nbautoexport/nbautoexport.py 98.91% <100.00%> (+4.35%) :arrow_up:
nbautoexport/sentinel.py 100.00% <100.00%> (ø)
nbautoexport/utils.py 100.00% <100.00%> (ø)
... and 4 more

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 31a9d6f...a44bae0. Read the comment docs.

jayqi commented 4 years ago

@pjbull @ejm714 @r-b-g-b

Okay, I think this should be ready to go.