Closed jayqi closed 4 years ago
Merging #38 into master will decrease coverage by
0.1%
. The diff coverage is96.9%
.
@@ Coverage Diff @@
## master #38 +/- ##
========================================
- Coverage 98.3% 98.1% -0.2%
========================================
Files 8 8
Lines 357 381 +24
========================================
+ Hits 351 374 +23
- Misses 6 7 +1
Impacted Files | Coverage Δ | |
---|---|---|
nbautoexport/nbautoexport.py | 98.2% <96.0%> (-0.7%) |
:arrow_down: |
nbautoexport/jupyter_config.py | 96.5% <100.0%> (+0.1%) |
:arrow_up: |
nbautoexport/sentinel.py | 100.0% <100.0%> (ø) |
@r-b-g-b I think the issue you had should be fixed. Ready for another look.
Splitting
install
commandinstall
into two commands:install
installs the post-save hook initialization in the Jupyter configconfigure
creates the.nbautoexport
configuration file in a directoryconfigure
command, if the post-save hook initialization is absent or out-of-date, there will be a warning printed.--jupyter-config
option toinstall
if user wants to install the post-save hook initialization to a Jupyter config in a nonstandard location.Other
clean
configuration option was not being passed throughinstall_sentinel
. Fixed by changing the interface ofinstall_sentinel
to accept a config object instead specifying each option. This reduces likelihood of similar future bugs by reducing the number of places that reproduce theNbAutoexportConfig
interface.pkg_resources.parse_version
withpackaging.version.parse
. This is whatpkg_resources
calls under the hood and is a lighter-weight dependency..codecov
configuration to:reach
graph, which I never found that interpretable but is really visually obnoxious.Closes #34. I did not unify the naming and opened #37 separately to avoid adding noise to this PR's diff.