Closed ejm714 closed 2 years ago
Merging #191 (47fceda) into master (7986c41) will decrease coverage by
0.2%
. The diff coverage isn/a
.
@@ Coverage Diff @@
## master #191 +/- ##
========================================
- Coverage 85.2% 85.0% -0.3%
========================================
Files 30 30
Lines 1854 1832 -22
========================================
- Hits 1581 1558 -23
- Misses 273 274 +1
Impacted Files | Coverage Δ | |
---|---|---|
zamba/version.py | 80.0% <0.0%> (-20.0%) |
:arrow_down: |
zamba/data/video.py | 80.2% <0.0%> (-0.8%) |
:arrow_down: |
zamba/models/densepose/config.py | 92.2% <0.0%> (-0.2%) |
:arrow_down: |
zamba/models/config.py | 97.0% <0.0%> (-0.2%) |
:arrow_down: |
zamba/models/model_manager.py | 84.0% <0.0%> (-0.1%) |
:arrow_down: |
zamba/models/utils.py | 100.0% <0.0%> (ø) |
@pjbull let me know if this looks good to you, and if so, i'll cut a new release
Looks good to me. Can we see if thop is going to fix this, and if so add an issue to revisit this pin when they have a new release?
Added an issue to track that: https://github.com/drivendataorg/zamba/issues/192
With the latest thop version released on June 10, 2022,
thop
requires onnx but doesn't install it. Our options are either to use an earlier version of thop or add the onnx dependency ourselves. Given that we don't need to use onnx, I've implemented the former.The current error is as follows:
This is further justification for setting up weekly test runs to catch this, per #188
Bonus fix: use less than or equals for
protobuf
as this consistently gets downgraded to 3.19.*.