search

drivendataorg / zamba

A Python package for identifying 42 kinds of animals, training custom models, and estimating distance from camera trap videos
https://zamba.drivendata.org/docs/stable/
MIT License
118 stars 27 forks source link

attempt to fix issue 198 #269

Closed esterguri closed 1 year ago

esterguri commented 1 year ago

We added a check to see if the default value is being used or if the user is setting the value.

netlify[bot] commented 1 year ago

Deploy Preview for silly-keller-664934 ready!

Name Link
Latest commit 34f8cf7c615a3a163e5cc2ffe4d78f02f32ea11d
Latest deploy log https://app.netlify.com/sites/silly-keller-664934/deploys/643cdc988e3fd5000871e26f
Deploy Preview https://deploy-preview-269--silly-keller-664934.netlify.app
Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

ejm714 commented 1 year ago

This PR is misunderstanding the intent of issue #198. The goal in that issue is to avoid the warning about providing split proportions if this is just the default value that is there. This PR still logs that error and just changes the default value.

The fix may entail adding a clause in the top line of this block that checks if the values are not the default ones before surfacing this error https://github.com/drivendataorg/zamba/blob/1ebcd4168c2cc5df0df9cbb6299f7aada0f7baa4/zamba/models/config.py#L524-L529