search

driver-oss / spray-json-derivation

Easy JSON formats for any case classes, for Scala, ScalaJS and Scala Native
Apache License 2.0
11 stars 3 forks source link

support missing parameters as None #5

Closed fommil closed 6 years ago

fommil commented 6 years ago

a field

foo: Option[Foo]

can be missing in the JSON or even null. But it looks like this decoder just fails.

jodersky commented 6 years ago

Sorry I wasn't subscribed to notifications and just now saw this issue. I'll take a look at it.

fommil commented 6 years ago

awesome

fommil commented 6 years ago

Thanks!

jodersky commented 6 years ago

Sorry it took so long. Jon Pretty (maintainer of Magnolia) is quite busy at the moment, so we decided to use our own published version of magnolia. The changes are minimal (see magnolia/#85), and we'll update the dependency to Magnolia proper as soon as possible.

jodersky commented 6 years ago

(Also, I committed the unspeakable act of rebasing and force-pushing to master to fix a MiMa incompatibility issue in the latest commit. Sorry for the inconvenience, I didn't think you'd be working with this project at this time of day :).)

fommil commented 6 years ago

My son was crying and woke me up. Now he's sleeping and I'm reading tickets on GitHub on my phone :-)

Jon doesn't believe in publishing anymore. He wrote a build tool that won't even let you do it because he hates it so much.

jodersky commented 6 years ago

That's definitely a good way to to pass time!

I heard rumors about this build tool, would love to check it out. With cbt and mill, it seems they're the hot topic of 2018 in the Scala community! We're hosting a meetup about Scala build tools next week, it's going to be quite interesting.