search

drizzle-team / drizzle-orm

Headless TypeScript ORM with a head. Runs on Node, Bun and Deno. Lives on the Edge and yes, it's a JavaScript ORM too 😅
https://orm.drizzle.team
Apache License 2.0
21.47k stars 486 forks source link

Upgrade and migrate drizzle-valibot to v0.31.0 #2481

Open fabian-hiller opened 3 weeks ago

fabian-hiller commented 3 weeks ago

This PR is not perfect and not finished as I had many questions. I added some TODO: to the code with more details. I also did not change the pnpm-lock.yaml file because my version of pnpm automatically updates it to lockfileVersion: '9.0'.

There is also another PR migrating to Valibot to v0.31.0 with #2477

Hint: BaseSchema is the type we use internally because it forces us to define all generics. This reduces errors on our end. For end users, Valibot also exports the GenericSchema type, which can be used to simplify the code.

dankochetov commented 3 weeks ago

@fabian-hiller pnpm-lock is 9.0 now in main so you can update it

fabian-hiller commented 3 weeks ago

Done

fabian-hiller commented 2 weeks ago

@drizzle-team feel free to take over this PR and reach out if you have any questions. I am happy to help!

CestDiego commented 1 week ago

What steps would be needed to finish this off from the drizzle-valibot perspective? :)

fabian-hiller commented 1 week ago

Review my changes and answer or fix my TODO: comments. I am happy to help.