Closed RemiPeruto closed 2 months ago
@philippdormann You reviewed the same changes back in march of this year in the MR https://github.com/drizzle-team/drizzle-orm/pull/1664 If it is still ok for you could you please approve my MR to merge those changes. Thanks a lot !
@RemiPeruto @AndriiSherman This PR would actually fix an issue in my project, could you review it please?
Thanks a lot! It looks great and is ready to merge. However, if you can resolve the conflicts, that would be helpful.
I can explain why there are conflicts and what should be done. Previously, all tests were separated by drivers, and now we have a *.common.ts file, for example, tests/pg/pg.common.ts, where all tests for pg are located and will be run in each driver automatically. There is no need to copy tests through all the files
@AndriiSherman thanks a lot ! I corrected the conflicts. Can you review please ?
@AndriiSherman Could you review it please ? It would be nice to have this feature. Like @ThomasAribart said, it will fix some issues in my project.
@RemiPeruto Could you please format all the files that you changed so they can pass dprint checks?
I am on it.
Going to make a few releases today. This one will be included
close https://github.com/drizzle-team/drizzle-orm/issues/1295
Make inArray and notInArray methods accept an empty list as their second parameter instead of throwing an error :
the comment referencing the choice of implementation in the thread