Closed JBPressac closed 3 years ago
Hello @drkane I tried several times to pull a request fir this issue but each time the checks fail during linting process. I also applied linting with Black and isort locally to avoid this problem, but this does not prevent GitHub to apply linting during check process. If you have any idea of the causes of this...
By the way, I do not understand the following command to install dependencies and tests:
pip install -e '.[test]'
I successfully tried (on Microsoft Windows):
pip install -e " C:\Users\jean-\Documents\GitHub\datasette-reconcile\"
Where C:\Users\jean-\Documents\GitHub\datasette-reconcile\ is the path to my local datasette-reconcile Git repository. But I don't understand what thoses brackets mean. And I am wondering if you did not mean "tests" instead of "test", referring to the tests folder ?
Thank you,
See the updates in pr #24 - let me know what you think.
In terms of installing the dependencies, it may be easier to run pip install dev-dependencies.txt
instead - that should have everything you need.
Thank you very much for the updates and dependencies installation tip.
Hello, As for the Wikidata reconcile API, the view template for entities could not have the same domain as the reconciliation API (OpenRefine displays Wikidata candidates with an URL as https://www.wikidata.org/wiki/{{id}}). Would it be possible to add a new plugin configuration item to eventually replace the datasette instance URL (as specified below) for the "view" by a combination of a domain given as parameter and the id_field.
https://github.com/drkane/datasette-reconcile/blob/d71fcade9f5e106e2ee2f39fe7586df6cd7eec6c/datasette_reconcile/reconcile.py#L97
To be more concise, would it be possible to modify the domain of the URLs of the candidates:
Thanks,