search

drkane / datasette-reconcile

Adds a reconciliation API endpoint to Datasette, based on the Reconciliation Service API specification.
MIT License
22 stars 6 forks source link

Added new parameter to configure the view domain #23

Closed JBPressac closed 3 years ago

JBPressac commented 3 years ago

Added new parameter to configure the view domain. Useful when the link to the candidates displayed in OpenRefine should be different from the Datasette table. Implemented in response to https://github.com/drkane/datasette-reconcile/issues/20#issue-905714304.

drkane commented 3 years ago

Looks good, thanks. Not sure why it's failing the linting - I can take a look.

The one suggestion I might make is instead of just specifying the view domain we should specify the whole view URL. The {{id}} parameter might not necessarily be at the end of the URL. We could add a check on initialisation to make sure that the URL has {{id}} somewhere in it.

drkane commented 3 years ago

I've incorporated the changes into pr #24 - I've changed it to a view_url parameter rather than viewDomain so that you can have the {{id}} anywhere in the URL. Let me know what you think.