I believe I fixed the model_frame() function. I wasn't using all the arguments to each function in lmabc, glmabc, and cv.penlmabc. I updated that by accepting ... in model_frame() and passing all the arguments from the earlier functions.
I also updated the introduction vignette with a few minor changes. I didn't see anywhere else that needed updates. I did file a new issue (#36) because I noticed names can get messy if a user runs code like lmabc(rbinom(nrow(df), 1, 0.5) ~ disp + cyl + disp:cyl, df). (This issue existed earlier, but we never tested passing a column name like rbinom(nrow(df), 1, 0.5). Now that users can pass any vector from the environment, the problem surfaced.)
I believe I fixed the
model_frame()function. I wasn't using all the arguments to each function inlmabc,glmabc, andcv.penlmabc. I updated that by accepting...inmodel_frame()and passing all the arguments from the earlier functions.I also updated the introduction vignette with a few minor changes. I didn't see anywhere else that needed updates. I did file a new issue (#36) because I noticed names can get messy if a user runs code like
lmabc(rbinom(nrow(df), 1, 0.5) ~ disp + cyl + disp:cyl, df). (This issue existed earlier, but we never tested passing a column name likerbinom(nrow(df), 1, 0.5). Now that users can pass any vector from the environment, the problem surfaced.)