search

drkowal / lmabc

https://drkowal.github.io/lmabc/
GNU General Public License v3.0
0 stars 0 forks source link

Temp solution for BIC issue #5

Closed prayaggordy closed 2 years ago

prayaggordy commented 2 years ago

Ugh! I can't figure out the right way to fix this. For now, I've used usethis::use_import_from("stats", "BIC") to add importFrom(stats,BIC) to the NAMESPACE file. The question of the century is why AIC.lmabc is totally fine but BIC.lmabc spits out warnings.

This solution should be fine for now—it removes the BIC-related warnings—but eventually we should revisit.

virginiabaskin commented 2 years ago

Also, there is the same problem for nobs but not other functions like vcov. Added import statement for nobs fixed it, but it feels so random.

virginiabaskin commented 2 years ago

Ran check() and no new errors, warnings, or notes were returned. Checked values in sandbox and the outputs were the same as main. Looks good to go!